Smooth normal calculation Update! #941
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 18, 2025 13:31
…eldVertices into CVertexWelder
added 7 commits
November 2, 2025 07:37
…d of std::function
| { | ||
| private: | ||
|
|
||
| static bool isIntegralElementEqual(const ICPUPolygonGeometry::SDataView& view, uint32_t index1, uint32_t index2) |
There was a problem hiding this comment.
all these static functions need to be static inline
Comment on lines
+112
to
+117
| bool init(const ICPUPolygonGeometry* polygon) override | ||
| { | ||
| return polygon->valid(); | ||
| } | ||
|
|
||
| bool operator()(const ICPUPolygonGeometry* polygon, uint32_t index1, uint32_t index2) const override |
| return true; | ||
| } | ||
|
|
||
| ~DefaultWeldPredicate() override = default; |
Comment on lines
+138
to
+139
| template <VertexWelderAccelerationStructure AccelStructureT> | ||
| static core::smart_refctd_ptr<ICPUPolygonGeometry> weldVertices(const ICPUPolygonGeometry* polygon, const AccelStructureT& as, const WeldPredicate& shouldWeldFn) { |
| return pass<RandomIt,KeyAccessor,0ull>(input,output,rangeSize,comp); | ||
| } | ||
|
|
||
| std::pair<histogram_t, histogram_t> getMostSignificantRadixBound(size_t key) const |
| VxCmpFunction vxcmp = [](const CPolygonGeometryManipulator::SSNGVertexData& v0, const CPolygonGeometryManipulator::SSNGVertexData& v1, const ICPUPolygonGeometry* buffer) | ||
| SSNGVxCmpFunction vxcmp = [](const CSmoothNormalGenerator::SSNGVertexData& v0, const CSmoothNormalGenerator::SSNGVertexData& v1, const ICPUPolygonGeometry* buffer) | ||
| { | ||
| static constexpr float cosOf45Deg = 0.70710678118f; |
There was a problem hiding this comment.
constexpr static inline
| }; | ||
|
|
||
| static core::smart_refctd_ptr<ICPUPolygonGeometry> createUnweldedList(const ICPUPolygonGeometry* inGeo); | ||
| static inline core::smart_refctd_ptr<ICPUPolygonGeometry> createUnweldedList(const ICPUPolygonGeometry* inGeo); |
There was a problem hiding this comment.
why did you add inline here, the function is defined in a Cpp file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list: